Skip to content

docs: update sample app links to correct sdk-sample-apps paths#589

Merged
vatsalparikh merged 1 commit into
developfrom
fix/update-sample-app-links
Jun 26, 2026
Merged

docs: update sample app links to correct sdk-sample-apps paths#589
vatsalparikh merged 1 commit into
developfrom
fix/update-sample-app-links

Conversation

@vatsalparikh

@vatsalparikh vatsalparikh commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Updated stale sample app links in README.md and packages/javascript-sdk/README.md to point to their correct locations in the sdk-sample-apps repo
  • All four samples (embedded login, central login, React Todo, Angular Todo) now point to archived paths since those are the ones that use @forgerock/javascript-sdk; the active samples have migrated to newer modular clients

Test plan

  • Verify all four sample links in root README.md resolve correctly on GitHub
  • Verify the .env.example path in packages/javascript-sdk/README.md Getting Started steps resolves correctly

@changeset-bot

changeset-bot Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9652ddf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 813a600

Command Status Duration Result
nx affected -t build lint test docs e2e-ci ✅ Succeeded 56s View ↗
nx-cloud record -- nx format:check --verbose ✅ Succeeded 4s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-06-25 22:49:03 UTC

@vatsalparikh vatsalparikh requested a review from cerebrl June 25, 2026 22:42
@vatsalparikh vatsalparikh force-pushed the fix/update-sample-app-links branch from 813a600 to 9652ddf Compare June 25, 2026 22:45
@pkg-pr-new

pkg-pr-new Bot commented Jun 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/javascript-sdk@589

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/ping-protect@589

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/token-vault@589

commit: 9652ddf

@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.72%. Comparing base (60e6ffb) to head (9652ddf).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #589      +/-   ##
===========================================
- Coverage    58.53%   56.72%   -1.81%     
===========================================
  Files          105      105              
  Lines        28448    28457       +9     
  Branches      1802     1644     -158     
===========================================
- Hits         16652    16143     -509     
- Misses       11796    12314     +518

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vatsalparikh vatsalparikh merged commit 5562651 into develop Jun 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteinGabriel SteinGabriel SteinGabriel approved these changes
@ancheetah ancheetah Awaiting requested review from ancheetah
@ryanbas21 ryanbas21 Awaiting requested review from ryanbas21
@cerebrl cerebrl Awaiting requested review from cerebrl

Assignees

No one assigned

Labels

docs root sdk

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vatsalparikh @codecov-commenter @SteinGabriel